Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdated redirects.json to change the destination for source "/pints" from "https://lu.ma/7j6g06rq" to "/adag1o/1" with the "permanent" flag unchanged (false). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/middleware.ts (2)
21-24: Harden the /pints redirect (trailing slash, query preservation, explicit 302).As written,
/pints/won’t match, and any query/UTM params are dropped. If that’s unintentional, tighten the check and preserve search params; also set a temporary status explicitly.
- Confirm intent: should
/pints?promo=...&id=...still go to the promo flow, or must everything under/pintsgo to/adag1o/1during the event?- Please also confirm the target slug spelling: is it
adag1o(digit “1”) oradagio/adag10?Apply:
- // redirect /pints -> /adag1o/1 - if (request.nextUrl.pathname === '/pints') { - return NextResponse.redirect(new URL('/adag1o/1', request.url)) - } + // redirect /pints[/] -> /adag1o/1 (temporary) + const pathname = request.nextUrl.pathname + if (pathname === '/pints' || pathname === '/pints/') { + const target = new URL('/adag1o/1', request.url) + // optional: preserve query string (e.g., UTM params). Drop this block if not desired. + if (url.search) target.search = url.search + return NextResponse.redirect(target, 302) + }
52-55: Matcher tweak and comment clarity.Including
/pintsin the matcher is correct. Minor nit: update the comment to reflect both/and/pints.-// Updated matcher to include root path +// Updated matcher to include '/' (root) and '/pints' (event redirect) export const config = { - matcher: ['/', '/pints', '/claim/:path*', '/api/:path*'], + matcher: ['/', '/pints', '/claim/:path*', '/api/:path*'], }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/middleware.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Deploy-Preview
This reverts commit b9ffcc4.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
redirects.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Deploy-Preview
🔇 Additional comments (1)
redirects.json (1)
39-42: LGTM: temporary redirect to internal path looks correct
- Matches PR intent; 307 (permanent=false) is appropriate for an event link.
No description provided.